Next release #74
Merged
Next release #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r necessary to add PYTHONPATH to models directory
Next release
Conflicts: applications/PUfoam/MoDeNaModels/FoamConstruction/run
restoring missing files for foam reconstruction (deleted at merging)
Fixed 'strange problem', forgot to define IndsxSet
added 4 commits
January 22, 2016 09:59
Merge remote-tracking branch 'upstream/nextRelease' into nextRelease "Merging Henriks MoDeNa nextReleaseO" Merge remote-tracking branch 'upstream/nextRelease' into nextRelease "Merging Henriks MoDeNa nextReleaseO"
…'m' for the surrogate model definitions
|
Contains SpherePackFB.exe AND duplicates contaminated history. Rejected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding module names:
Do we want to force the author of an application to give the python module the same name as the surrogate model
_id?Using the current structure the following is required (according to method
loadFromModuleinSurrogateModel.py):Surrogate model:
And the directory structure:
Alternatively it would be possible to parse all the modules to locate the appropriate
_idbefore importing the module.